topic Bug in ippimage.cpp:1387 (CIppImage::ToGray) in Intel® Integrated Performance Primitives

Bug in ippimage.cpp:1387 (CIppImage::ToGray)

idana — Mon, 23 Jan 2012 11:34:38 GMT

Hello,

The problem is in CIppImage::ToGray(CIppImage& img, const float* coeffs)

The test below will allways return, and it should not:

if( NChannels() != 3 || NChannels() != 4 )

return -1;;

I think that AND should be used instead of OR:

if( NChannels() != 3 && NChannels() != 4 )

return -1;;

Thank you.

Bug in ippimage.cpp:1387 (CIppImage::ToGray)

Naveen_G_Intel — Tue, 24 Jan 2012 06:28:51 GMT

Hi,

Just I verified picnic application with converting from RGB to Gray scale, it works fine, so coding logic should be correct.

Are you getting any error in the result of this function?

Thanks,

Naveen Gv

Bug in ippimage.cpp:1387 (CIppImage::ToGray)

Thomas_Jensen1 — Tue, 24 Jan 2012 08:46:15 GMT

You are wrong: the code says "if not rgb24 or not rgb32 then don't do it".

Bug in ippimage.cpp:1387 (CIppImage::ToGray)

idana — Tue, 24 Jan 2012 09:03:10 GMT

I use the following IPP version:

7.0 build 205.58, [7.0.1032.205]

I used this specific function from my application and it returned -1 for color images.

The function should work if the image is rgb24 or rgb32, that is

if (!(rgb24 || rgb32))return -1;

This is equivalent to:

if (!rgb24 && !rgb32)return -1;

So the code should say"if not rgb24 AND not rgb32 then don't do it".

Thank you.

Bug in ippimage.cpp:1387 (CIppImage::ToGray)

Thomas_Jensen1 — Tue, 24 Jan 2012 10:17:06 GMT

Hmm, I guess you are correct. It is too early in the morning here...

For rgb24, it would look like this:

if( 3 != 3 || 3 != 4 )
return -1;

This will always return -1 !

Naveen checked in Picnic, but I cannot find any grayscale functions in Picnic.

I also searched for ToGray() references in the source code of Picnic, but I didn't find any references except the implementation.

Naveen, can you clarify?

Bug in ippimage.cpp:1387 (CIppImage::ToGray)

Sergey_K_Intel — Tue, 24 Jan 2012 11:42:35 GMT

Quoting idana@picscout.com

I think that AND should be used instead of OR:
Hello,
if( NChannels() != 3 && NChannels() != 4 )
return -1;

That's true. We will fix it. Probably, there were assertions before with "assert(NChannels==3 || NChannels==4)". When substituting with "if", the expression must be turned inside out completely "NChannels!=3 && NChannels!=4"

Thank you,

Sergey