icpc - Thread_local an classes with "constructor = default" leads to multiple call to destructor

johanM — Wed, 11 Dec 2024 11:10:38 GMT

Hi,
we have in our code some thread_local homemade containers in order to don't reallocate them at each call of thread function, and recently we added "=default" in a constructor instead of "{}", and this result in a strange behavior : at the end of the thread, the destructor began to be called as much as the function was called inside the thread, and as we have a free on a pointer in the destructor the application began to crash on "double free" error.

I have made a simple example of it:

#include <iostream> #include <thread> class youpela{ float toto{}; public: constexpr youpela() noexcept = default; ~youpela(){ printf("delete_youpela\n"); // Here if I free a pointer : double delete if my_func was called at least twice } }; void my_func() { thread_local youpela boom; printf("leaving my_func()\n"); } void my_thread_func() { my_func(); my_func(); } int main() { printf("main\n"); std::thread my_thread(my_thread_func); my_thread.join(); return 0; }

And on compiler explorer, this behavior is only observable by using icc (icpc in our case). GCC/icx don't have this behavior the constructor is only called once, instead of twice with icpc.

This behavior is clearly not expected, and in our case we call a lot of time this method, resulting in a huge loop on destruction for each threads I guess.

Can someone explain/fix this? It seems it is not fixed on latest icpc versions.

Thanks

Re: icpc - Thread_local an classes with "constructor = default" leads to multiple call to

johanM — Wed, 11 Dec 2024 11:13:22 GMT

Little update, by removing "=default" and replacing by "{}" the destructor will only be called once.

Re: icpc - Thread_local an classes with "constructor = default" leads to multiple call to

Viet_H_Intel — Wed, 11 Dec 2024 16:59:20 GMT

Intel C++ Compiler Classic (icc/icpc) has been end of life. We will not fix or release a new version of icc/icpc any more. Please migrate your code to oneAPI DPC++/C++ Compiler (icx/icpx)

topic Re: icpc - Thread_local an classes with "constructor = default" leads to multiple call to in Intel® oneAPI DPC++/C++ Compiler

icpc - Thread_local an classes with "constructor = default" leads to multiple call to destructor

Re: icpc - Thread_local an classes with "constructor = default" leads to multiple call to

Re: icpc - Thread_local an classes with "constructor = default" leads to multiple call to