Risk of infinite loop when using weak_ptr on Windows

Jean-Jacques — Mon, 05 Dec 2022 08:11:07 GMT

From the disassembler view, it seems the implementation of weak_ptr::lock in Windows SGX SDK is similar to the Linux one :

__shared_weak_count* __shared_weak_count::lock() _NOEXCEPT { long object_owners = __libcpp_atomic_load(&__shared_owners_); while (object_owners != -1) { if (__libcpp_atomic_compare_exchange(&__shared_owners_, &object_owners, object_owners+1)) return this; } return nullptr; }

However the compare_exchange function ends up being this piece of code from include\libc++\support\win32\atomic.h :

template<class _Tp> static inline bool __atomic_compare_exchange_strong_explicit(volatile _Tp *__val, volatile _Tp *__expected, _Tp __after, int, int) { return _atomic_msvc_wrapper::FetchClass<sizeof(_Tp)>::compare_exchange<_Tp>(__val, *__expected, __after); }

This implementation is incorrect, as it loses the feature that if the exchange doesn't happen, the current value of __val is written to __expected. As a result, if indeed there has been a change between the load on line 4 and the exchange on line 7, object_owners is not modified, and the loop continues, possibly forever (if the value doesn't come back to what it was).

This happens sometimes in our code, during shutdown, when many shared or weak pointers are released concurrently.

Re:Risk of infinite loop when using weak_ptr on Windows

Sahira_Intel — Tue, 06 Dec 2022 01:03:23 GMT

Hi,

I have escalated this issue for further feedback and will let you know when I have more information.

Sincerely,

Sahira

Re:Risk of infinite loop when using weak_ptr on Windows

Sahira_Intel — Wed, 07 Dec 2022 20:08:22 GMT

Hi,

This is a bug and the engineering team is working on fixing it.

Sincerely,

Sahira

topic Re:Risk of infinite loop when using weak_ptr on Windows in Intel® Software Guard Extensions (Intel® SGX)

Risk of infinite loop when using weak_ptr on Windows

Re:Risk of infinite loop when using weak_ptr on Windows

Re:Risk of infinite loop when using weak_ptr on Windows