Unable to compile e810 driver ice-1.6.7 on RHEL8.4

[davidnoh]

I attempted to compile the driver however keep getting errors. Originally, I tried with the latest 1.8 which compiled and loaded but was having issues.  I later found out by support that it has bugs and was told to use 1.6.7 instead, however this version fails to compile. 

# make install

echo "*** The target kernel has CONFIG_MODULE_SIG_ALL enabled, but" ; echo "*** the signing key cannot be found. Module signing has been" ; echo "*** disabled for this build." ; make ccflags-y="" -C "/lib/modules/4.18.0-348.20.1.el8_5.x86_64/source" CONFIG_ICE=m CONFIG_MODULE_SIG=n CONFIG_MODULE_SIG_ALL= M="/home/labuser/e810Driver/ice-1.6.7/src" modules
*** The target kernel has CONFIG_MODULE_SIG_ALL enabled, but
*** the signing key cannot be found. Module signing has been
*** disabled for this build.
make[1]: Entering directory '/usr/src/kernels/4.18.0-348.20.1.el8_5.x86_64'
CC [M] /home/labuser/e810Driver/ice-1.6.7/src/ice_main.o
In file included from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
/home/labuser/e810Driver/ice-1.6.7/src/kcompat.h: In function ‘_kc_xdp_rxq_info_reg’:
/home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:3524:9: error: too few arguments to function ‘xdp_rxq_info_reg’
return xdp_rxq_info_reg(xdp_rxq, dev, queue_index);
^~~~~~~~~~~~~~~~
In file included from ./include/linux/netdevice.h:47,
from ./include/linux/etherdevice.h:26,
from /home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:15,
from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
./include/net/xdp.h:267:5: note: declared here
int xdp_rxq_info_reg(struct xdp_rxq_info *xdp_rxq,
^~~~~~~~~~~~~~~~
In file included from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
/home/labuser/e810Driver/ice-1.6.7/src/kcompat.h: In function ‘_kc_napi_busy_loop’:
/home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:3539:2: error: too few arguments to function ‘napi_busy_loop’
napi_busy_loop(napi_id, loop_end, loop_end_arg);
^~~~~~~~~~~~~~
In file included from /home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:3532,
from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
./include/net/busy_poll.h:58:6: note: declared here
void napi_busy_loop(unsigned int napi_id,
^~~~~~~~~~~~~~
In file included from ./include/net/devlink.h:24,
from /home/labuser/e810Driver/ice-1.6.7/src/kcompat_impl.h:149,
from /home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:3556,
from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
./include/uapi/linux/devlink.h: At top level:
./include/uapi/linux/devlink.h:258: warning: "DEVLINK_FLASH_OVERWRITE_SETTINGS" redefined
#define DEVLINK_FLASH_OVERWRITE_SETTINGS _BITUL(DEVLINK_FLASH_OVERWRITE_SETTINGS_BIT)

In file included from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
/home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:3476: note: this is the location of the previous definition
#define DEVLINK_FLASH_OVERWRITE_SETTINGS BIT(0)

In file included from ./include/net/devlink.h:24,
from /home/labuser/e810Driver/ice-1.6.7/src/kcompat_impl.h:149,
from /home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:3556,
from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
./include/uapi/linux/devlink.h:259: warning: "DEVLINK_FLASH_OVERWRITE_IDENTIFIERS" redefined
#define DEVLINK_FLASH_OVERWRITE_IDENTIFIERS _BITUL(DEVLINK_FLASH_OVERWRITE_IDENTIFIERS_BIT)

In file included from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
/home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:3480: note: this is the location of the previous definition
#define DEVLINK_FLASH_OVERWRITE_IDENTIFIERS BIT(1)

In file included from /home/labuser/e810Driver/ice-1.6.7/src/kcompat_impl.h:149,
from /home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:3556,
from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
./include/net/devlink.h:609:8: error: redefinition of ‘struct devlink_flash_update_params’
struct devlink_flash_update_params {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/labuser/e810Driver/ice-1.6.7/src/ice.h:7,
from /home/labuser/e810Driver/ice-1.6.7/src/ice_main.c:8:
/home/labuser/e810Driver/ice-1.6.7/src/kcompat.h:3469:8: note: originally defined here
struct devlink_flash_update_params {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:316: /home/labuser/e810Driver/ice-1.6.7/src/ice_main.o] Error 1
make[1]: *** [Makefile:1571: _module_/home/labuser/e810Driver/ice-1.6.7/src] Error 2
make[1]: Leaving directory '/usr/src/kernels/4.18.0-348.20.1.el8_5.x86_64'
make: *** [Makefile:113: all] Error 2