Please fix TBB warnings

[e4lam]

Dear Devs,

Please fix the following TBB warnings (3.0 update 5):

Generating code
tbbmalloc\\backend.cpp(197) : warning C4706: assignment within conditional expression
tbbmalloc\\backref.cpp(177) : warning C4706: assignment within conditional expression
tbbmalloc\\backref.cpp(94) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(1047) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(1073) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(1407) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(1413) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(1637) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(1641) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(1653) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(1668) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(1681) : warning C4706: assignment within conditional expression
tbbmalloc\\frontend.cpp(2030) : warning C4702: unreachable code
tbbmalloc\\large_objects.cpp(212) : warning C4706: assignment within conditional expression
Finished generating code

Thanks!

[Alexey-Kukanov]

Forthe internal TBB code, we use more relaxed warning settings than for headers, because normal use of TBB is not affected.

These particular warning instances seem not require sophisticated workarounds and code clutter, so possibly we will fix it. In some other cases the cure for misguided warnings can be worse than the desease, due to significant code clutter introduced to workaround a benign diagnostic. It may complicate maintenance, and reduce overall code quality (by our team'sinternal standards). So generally we do not guarantee that internal code is warning-free for those who builds TBB from sources.