The proper way to cancel a ConcurrentQueue's Pop condition and his consumer thread

[poetinha]

Hi folks,

I'm currently migrating to TBB, anyway, I will have the same question... I've attached my sources to explain.

My consumer thread could be waiting on a queue.pop(), since it should be signaled on concurrent queue only... what's the better way to deal with this? I know that a queue will never have a terminate() method :P it's just a workaround for now.

Thanks in advance,

William

concurrent_queue-inl.h

test_consumer.h

[nagy]

Something like this maybe?

void terminate()

{

queue.push(nullptr);

}

void run()

{

History* hist = queue.pop();

bool terminated = hist == nullptr;

}

[poetinha]

pushing a NULL value works only on a blockingqueue, right?

[nagy]

I dont understand? pop() is blocking in all tbbs concurrent queues, try_pop is non-blocking. And why would it only work on a blockingqueue?

[poetinha]

My mistake. Thanks a lot. It solved my problem.

[Dmitry_Vyukov]

Quoting poetinha

My mistake. Thanks a lot. It solved my problem.

Be careful, some use patterns can corrupt memory/crash:

http://software.intel.com/en-us/forums/showthread.php?t=73928&o=d&s=lr