Intel® Fortran Compiler
Build applications that can scale for the future with optimized code designed for Intel® Xeon® and compatible processors.
29010 Discussions

Problem in documentation for quickwin GETVIEWCOORD

dboggs
New Contributor I
424 Views

The documentation says "translate phusical coordinates or window coordinates to viewport coordinates" OK. There are two variations:

CALL GETVIEWCOORD (x, y, t)

where inputs x, y are physical coordinates and are converted to output t, of type xycoord, which are viewport coordinates (integer(2)). OK

CALL GETVIEWCOORD_W (wx, wy, wt)

where inputs wx, wy are window coordinates and are converted to output wt, of type wxycoord, which are window coordinates (real(8)). !

Yes, that's what it says for the second case, and it makes no sense. What it should say is

CALL GETVIEWCOORD_W (wx, wy, t)

where inputs wx, wy are window coordinates and are converted to output t, of type xycoord, which are viewport coordinates (integer(2)).

It is not helpful to have a function to convert window coordinates into window coordinates!

0 Kudos
7 Replies
Steven_L_Intel1
Employee
424 Views

You're right - the output argument of GETVIEWCOORD_W should be described identically to that of GETVIEWCOORD. I will let our writers know - thanks.

0 Kudos
Steven_L_Intel1
Employee
424 Views

In addition, we'll fix the documentation to indicate that the third argument is named S and not T or WT, as that's how it's declared in IFQWIN.

0 Kudos
dboggs
New Contributor I
424 Views

Thanks Steve. But re your second message: since T or WT are user-defined names, it doesn't really matter, right? If you're just looking for consistency, note that these derived-type variables are also used in other routines (GETVIEWCOORD, GETWINDOWCOORD, GETCURRENTPOSITION, MOVETO, maybe others) and they are all described as T or WT in the documentation. So I've been using T or WT in most of my coding wherever I have no reason to change.

0 Kudos
Steven_L_Intel1
Employee
424 Views

It matters because the interfaces in IFQWIN use S as the argument name, so if you used argument keywords with T or WT you'd get an error.  For example:

CALL GETVIEWCOORD (X,Y,T=MYT)

If you aren't using keywords, then it doesn't matter. It is important that the documentation match the interface.

0 Kudos
dboggs
New Contributor I
424 Views

OK I can see that it matters if and only if you are using argument keywords. That never occurred to me. So are you going to change the documentation for all of the affected subroutines? A partial list for nomination is: GETVIEWCOORD, GETWINDOWCOORD, GETPHYSCOORD, GETCURRENTPOSITION, GETTEXTPOSITION, MOVETO, SETVIEWORG, POLYBEZIER, POLYBEZIERTO, POLYGON (all of the routines that use type xycoord?)

0 Kudos
Steven_L_Intel1
Employee
424 Views

I'll check those out, and if they need changes we'll make them. Thanks.

0 Kudos
Steven_L_Intel1
Employee
424 Views

Added GETARCINFO to the list.

0 Kudos
Reply