Crosswalk build fails with version 17 and 18 (16 OK)

[Andrea_C_]

Hi to everyone,

we are hit from this bug (so that we are not able to build are app), which was solved in that issue:

https://crosswalk-project.org/jira/browse/XWALK-6116

Do the current build systems have integrated this patch?

Thanks,

Andrea

[Andrea_C_]

Better explaination:

We obtain this error

:compileArmv7ReleaseJava.../cordova_project/platforms/android/src/org/crosswalk/engine/XWalkCordovaUiClient.java:71: error: onJsAlert(XWalkView,String,String,XWalkJavascriptResult) in XWalkCordovaUiClient cannot override onJsAlert(XWalkView,String,String,XWalkJavascriptResult) in XWalkUIClient
    private boolean onJsAlert(XWalkView view, String url, String message,
                    ^
  attempting to assign weaker access privileges; was public
.../cordova_project/platforms/android/src/org/crosswalk/engine/XWalkCordovaUiClient.java:89: error: onJsConfirm(XWalkView,String,String,XWalkJavascriptResult) in XWalkCordovaUiClient cannot override onJsConfirm(XWalkView,String,String,XWalkJavascriptResult) in XWalkUIClient
    private boolean onJsConfirm(XWalkView view, String url, String message,
                    ^
  attempting to assign weaker access privileges; was public
.../cordova_project/platforms/android/src/org/crosswalk/engine/XWalkCordovaUiClient.java:112: error: onJsPrompt(XWalkView,String,String,String,XWalkJavascriptResult) in XWalkCordovaUiClient cannot override onJsPrompt(XWalkView,String,String,String,XWalkJavascriptResult) in XWalkUIClient
    private boolean onJsPrompt(XWalkView view, String origin, String message, String defaultValue,
                    ^

when the inappbrowser plugin is included, which overrides these methods. Crosswalk webview had this method private until the patch was applied.

[PaulF_IntelCorp]

Andrea -- you can try using CW19 (and later) using this technique in the additions file:

<!-- Set the Crosswalk embedded library to something other than those listed in the UI -->
<!-- https://github.com/crosswalk-project/crosswalk-website/wiki/Release-dates -->
<!-- https://download.01.org/crosswalk/releases/crosswalk/android/maven2/org/xwalk/xwalk_core_library/ -->
<!-- https://download.01.org/crosswalk/releases/crosswalk/android/maven2/org/xwalk/xwalk_core_library_beta/ -->
<!-- https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview#configure -->
<!--<preference name="xwalkVersion" value="18+"/>-->
<!--<preference name="xwalkVersion" value="14.43.343.24" />-->
<!--<preference name="xwalkVersion" value="org.xwalk:xwalk_core_library_beta:19+" />-->

Obviously, you'll have to uncomment and change the version number to get what you want. When you do this, it overrides whatever is in the build settings AND will likely not work with the Debug tab builds. So, for example, if you wanted to build with CW19, you could do this:

<preference name="xwalkVersion" value="19+"/>

[Andrea_C_]

Yes, with the option:

<preference name="xwalkVersion" value="19+"/>

works, so watch out for this error!

[Andrea_C_]

Sorry Paul, I was building with crosswalk 16 :-(

With crosswalk 20 (latest stable version) I get the same error.

I am quite sure it depends on a outdated plugin  cordova-plugin-crosswalk-webview

This cannot be modified by our side (I think)

[Andrea_C_]

Figured out:

Crosswalk 17+ needs at least cordova cli 5.4.1.

By upgrading all the problems are solved.

[PaulF_IntelCorp]

Great news! :-)