[drivers]: Incorrect declarations for event strings

[TCR]

Hi everybody,

The i18n strings for the Windows event log are missing because of a mistake in the drivers.

The INF file contains: 

[win10.EventLog]
AddReg = win10.AddEventLog.reg

[win10.AddEventLog.reg]
HKR, , EventMessageFile, 0x00020000, "%%SystemRoot%%\System32\netevent.dll;%13%\e2fmsg.dll"
HKR, , TypesSupported, 0x00010001, 7

So the registry points to e2fmsg.dll in the destination directory for the event strings.

But one of your colleagues forgot to actually add e2fmsg.dll to the copy files section.
So e2fmsg.dll is missing from the destination directory.


Ironically the INF files for the Wi-Fi drivers (Netwtw6e.INF) and Bluetooth drivers (ibtusb.inf) also contain a mistake for the event messages.
In Netwtw6e.INF:

[Reg_CommonAddEventLog_10_WinT]
HKR,, EventMessageFile, 0x00020000, "%%SystemRoot%%\System32\netevent.dll;%%13%%\Netwtw10.sys"
HKR,, TypesSupported, 0x00010001, 7

[Reg_CommonAddEventLog_10_WinA]
HKR,, EventMessageFile, 0x00020000, "%%SystemRoot%%\System32\netevent.dll;%%13%%\Netwaw10.sys"
HKR,, TypesSupported, 0x00010001, 7

In ibtusb.inf:

; Event Log install section
;
[ibtusb_iBT_EventLog_Inst]
AddReg=ibtusb_iBT_EventLog_AddReg

[ibtusb_iBT_EventLog_AddReg]
HKR,,EventMessageFile,0x00020000,"%%SystemRoot%%\System32\IoLogMsg.dll;%%13%%\ibtusb.sys"
HKR,,TypesSupported,0x00010001,7

Adding variable declarations to the Windows registry by escaping them, of course, only works for environment variables like "SystemRoot".
The string "%13%" is now added to the registry instead of it's value. %%13%% should have been written as %13%.

13 is not a proper descriptive name.
Why is the same mistake made in multiple drivers? Isn't this properly tested?

With friendly regards,

[TCR]

I reported this half a year ago, because it was present in all Intel network drivers.

Now I get send back to make new incidents.

I'll just use a script to mitigate Intel's quality issues.

What is this? A comedy club?

Because it sure feels like amateur hour to me.