- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
I WRITE A PROGRAM FOR WATER QUALITY MODELLING. THIS PROGRAM CONTAINS WITH FIVE MODULE THIS THE FIRST ONE. ONE IS FOR THE MEDIAN VALUE CALCULATE. WHEN I COMBINED ALL MODULES INTO MAIN PROGRAM, THE COMPILER GAVE AN ERROR MEAASSES AS "error FOR2771: too few arguments in reference TO MODULE". I AM NEW USER IN FORTRAN. I AM SHEEKING SUPPORT TO SOLVE THIS PROBLEM. MANY THANKS FOR YOUR SUPPORTS. @andrew_4619
MODULE DATAMEDIAN
IMPLICIT NONE
REAL , DIMENSION (100):: X
INTEGER, PRIVATE :: I,J,K,L,N
REAL :: TEMP,MEDIAN
CONTAINS
SUBROUTINE MEDIANVALUE (X,N)
IMPLICIT NONE
REAL , DIMENSION (100):: X
INTEGER :: I,J,K,L,N
REAL :: TEMP,MEDIAN
OPEN(1, FILE = 'SALDATA07.DAT', STATUS='OLD')
OPEN(2, FILE = 'MEDIAN.DAT', STATUS='UNKNOWN')
READ (1,*) N
WRITE(*,*) 'NUMBERS OF INPUT DATA', N
READ(1,*) (X(I), I=1,N)
DO K=1, N-1
DO L=K+1,N
IF (X(K) .GT. X(L)) THEN
TEMP = X(K)
X(K) = X(L)
X(L) = TEMP
END IF
1 CONTINUE
IF (MOD(N,2) .EQ. 0.0) THEN
MEDIAN=(X(N/2.0)+X((N/2.0)+1))/2.0
ELSE
MEDIAN=X((N+1)/2.0)
END IF
END DO
END DO
WRITE(2,10) NINT(MEDIAN)
10 FORMAT (10I10)
WRITE(*,*) 'MEDIAN IS', MEDIAN
CLOSE(1)
CLOSE(2)
RETURN
END SUBROUTINE
END MODULE
PROGRAM MAIN
USE DATAMEDIAN
CALL MEDIANVALUE(X,N)
END PROGRAM
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
I don't know your program. The call to MEDIANVALUE needs two arguments passed to it. But looking at the routine, it seems to want to do everything internally, so you could just delete "(X,N)" in the SUBROUTINE MEDIANVALUE line.
I can't say whether the rest of the calls after line 700 are correct, but at least they aren't invalid Fortran.
Link Copied
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
I do not get that error with the code posted. What compiler version are you using?
1] always use implicit none ( it is not in your main program )
2] /warn:all and /stand are recommended (by me) for development codes.
I think that will help you a lot.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
Many thanks for your support.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
That is not an Intel Fortran error message. Is that Microsoft Fortran PowerStation?
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
That compiler is AT LEAST 23 years old and had many bugs. You seem to have found one. We can't help you with it - the code you have looks fine and would compile with a compiler from this century.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
I would suggest gfortran. Note that we can't help you with installation or use of non-Intel compilers in this forum.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
That compiler is AT LEAST 23 years old and had many bugs.
You mean very many -- as in a prime number not less than 12 digits.
using the one before the Internet lead to thoughts of .......
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
Uddin_md:
The source file compiles and links fine when Powerstation 4 is used. You probably received the reported error message when working with some other code.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
Dear ( @Steve_Lionel , @andrew_4619 , @mecej4 , @JohnNichols )All, Many thanks for your feed back. I placed my full program herein for your expertise knowledge to solve this issues. Again many thanks all.
MODULE DATAMED
IMPLICIT NONE
REAL , DIMENSION (100):: X
INTEGER, PRIVATE :: I,J,K,L,N
REAL :: TEMP,MEDIAN
CONTAINS
SUBROUTINE MEDIANVALUE (X,N)
IMPLICIT NONE
REAL , DIMENSION (100):: X
INTEGER :: I,J,K,L,N
REAL :: TEMP,MEDIAN
OPEN(1, FILE = 'SALDATA07.DAT', STATUS='OLD')
OPEN(2, FILE = 'MEDIAN.DAT', STATUS='UNKNOWN')
!DATA COUNT AND READ FROM INPUT FILE
READ (1,*) N
WRITE(*,*) 'NUMBERS OF INPUT DATA', N
READ(1,*) (X(I), I=1,N)
DO K=1, N-1
DO L=K+1,N
!DATA SWAP
IF (X(K) .GT. X(L)) THEN
TEMP = X(K)
X(K) = X(L)
X(L) = TEMP
IF (MOD(N,2) .EQ. 0.0) THEN
MEDIAN=(X(N/2.0)+X((N/2.0)+1))/2.0
ELSE
MEDIAN=X((N+1)/2.0)
END IF
END IF
END DO
END DO
WRITE(2,10) NINT(MEDIAN)
10 FORMAT (10I10)
WRITE(*,*) 'MEDIAN IS', MEDIAN
CLOSE(1)
CLOSE(2)
RETURN
END SUBROUTINE
END MODULE
!MODULE FOR STD CALCULATION
MODULE STD
IMPLICIT NONE
REAL :: MEDIAN, DIN,MRP,CHL,DOX, MRPDOX
CONTAINS
SUBROUTINE THRESHOLDS(MRPDOX)
IMPLICIT NONE
REAL :: MEDIAN, DIN,MRP,CHL,DOX, MRPDOX
OPEN (20, FILE ='MEDIAN.DAT', STATUS = 'OLD')
READ (20,*) MEDIAN
WRITE(*,*) 'MEDIAN=', MEDIAN
CLOSE(20)
IF (MEDIAN .EQ. 0) THEN
READ (*,*)
DIN = 2.60
MRP = 60.00
CHL = 15.00
DOX = 100.00
WRITE (*,10) DIN, MRP, CHL, DOX
10 FORMAT (10F10.2)
ELSE IF (MEDIAN .EQ. 1) THEN
READ (*,*)
DIN = 2.53
MRP = 60.00
CHL = 15.00
DOX = 100.00
WRITE (*,11) DIN, MRP, CHL, DOX
11 FORMAT (10F10.2)
ELSE IF (MEDIAN .EQ. 2) THEN
READ (*,*)
DIN = 2.46
MRP = 60.00
CHL = 15.00
DOX = 100.00
WRITE (*,12) DIN, MRP, CHL, DOX
12 FORMAT (10F10.2)
ELSE IF (MEDIAN .EQ. 3) THEN
READ (*,*)
DIN = 2.39
MRP = 60.00
CHL = 15.00
DOX = 100.00
WRITE (*,13) DIN, MRP, CHL, DOX
13 FORMAT (10F10.2)
ELSE IF (MEDIAN .EQ. 4) THEN
READ (*,*)
DIN = 2.32
MRP = 60.00
CHL = 15.00
DOX = 100.00
WRITE (*,14) DIN, MRP, CHL, DOX
14 FORMAT (10F10.2)
ELSE IF (MEDIAN .EQ. 5) THEN
READ (*,*)
DIN = 2.25
MRP = 60.00
CHL = 15.00
DOX = 100.00
WRITE (*,15) DIN, MRP, CHL, DOX
15 FORMAT (10F10.2)
ELSE IF (MEDIAN .EQ. 6) THEN
READ (*,*)
DIN = 2.18
MRP = 60.00
CHL = 15.00
DOX = 100.00
WRITE (*,16) DIN, MRP, CHL, DOX
16 FORMAT (10F10.2)
ELSE IF (MEDIAN .EQ. 7) THEN
READ (*,*)
DIN = 2.11
MRP = 60.00
CHL = 15.00
DOX = 100.00
WRITE (*,17) DIN, MRP, CHL, DOX
17 FORMAT (10F10.2)
ELSE IF (MEDIAN .EQ. - Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
You can attach source files rather than pasting a large program into a reply.
Line 125 is supposed to read:
ELSE IF (MEDIAN .EQ. 8 ) THEN
I think the forum turned it into an invisible emoji - I had to add a blank to disable that.
I would use SELECT CASE for these tests rather than a series of IF.
Line 700 calls MEDIANVALUE with no arguments, but the procedure takes two arguments. This may be what PowerStation was complaining about.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
@Steve_Lionel MANY THANKS FOR YOUR INSTANCE SUPPORT, UNFORTUNENTLY, LINE 125 DATA MISSID WHEN I PASTE INTO THIS PLATFORM, BUT MY MAIN PROGRAM IS OK, WHEN I CHECKED IT. THEN I RUN AGAIN BUT SIMILAR PROBLEM ARISEN. ALSO, I RUN THIS PROGRAM USING THE SILVERFORST COMPLILER. I FOUND SIMILAR ISSUES. DO YOU HAVE ANY RECCOMENDATIONS HOE COULD I SOLVE THIS ISSUES. MANY THANKS DEAR STEVE.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
I don't know your program. The call to MEDIANVALUE needs two arguments passed to it. But looking at the routine, it seems to want to do everything internally, so you could just delete "(X,N)" in the SUBROUTINE MEDIANVALUE line.
I can't say whether the rest of the calls after line 700 are correct, but at least they aren't invalid Fortran.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
Dear @Steve_Lionel , thank you so much for your support. It's solved my program issue by following your important suggestions. Now it is working fine and I got my target outputs.
Many thanks again
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
Uddin_md:
You wrote "ALSO, I RUN THIS PROGRAM USING THE SILVERFORST COMPLILER. I FOUND SIMILAR ISSUES. DO YOU HAVE ANY RECCOMENDATIONS HOE COULD I SOLVE THIS ISSUES."
I am afraid that what you are asking for is not reasonable, and nearly impossible.
A program is (I) an expression of ideas using (2) the syntax rules of a programming language, and there are often issues that arise when (3) using a compiler and running the program on a class of computers.
We can help with (2) and (3). With (1), if one of us happens to work in the same field, there is a chance of helping.
In the present case, I have to say that I know nothing about what your program is supposed to be doing. If you can describe the calculation, its purpose and algorithms used, some progress may be possible.
Nevertheless, you should seek help from the author of the program, if the author is known and available.
Or, better, write your own program and then you will be in a better position to discuss its behavior and shortcomings.
- Subscribe to RSS Feed
- Mark Topic as New
- Mark Topic as Read
- Float this Topic for Current User
- Bookmark
- Subscribe
- Printer Friendly Page